Fix file exists checker #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main problem was that the file exists checker uses go's built in filepath globber, which doesn't support double-asterisk patterns (golang/go#11862). Additionally, with patterns like `*.js` we need to search for all JS files not only on the first level but also in nested directories. Based on made investigation this problem was fixed and additional test covereage was added to document that contract.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 18.26% 24.76% +6.49%
==========================================
Files 10 10
Lines 312 323 +11
==========================================
+ Hits 57 80 +23
+ Misses 252 239 -13
- Partials 3 4 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main problem was that the file exists checker was using Go's built-in
filepath.Globmethod which doesn't support double-asterisk patterns.Additionally, with patterns like
*.jswe need to search for all JS files, not only on the first level but also in nested directories.Based on made investigation this problem was fixed and additional test coverage was added to document that contract.
Related issue(s)
Fixes #42
Fixes #22