Ignore ghost user

[miguelslemos]

Description
Add ignore case for user @ghost https://git.luolix.topmunity/t5/How-to-use-Git-and-GitHub/CODEOWNERS-file-with-a-NOT-file-type-condition/m-p/31013/highlight/true#M8523

Related issue(s)

Fixes #52

[codecov]

Codecov Report

Merging #53 into master will increase coverage by 2.00%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   43.81%   45.82%   +2.00%     
==========================================
  Files          12       13       +1     
  Lines         372      371       -1     
==========================================
+ Hits          163      170       +7     
+ Misses        207      199       -8     
  Partials        2        2              

Impacted Files	Coverage Δ
internal/check/valid_owner.go	10.78% <0.00%> (+0.87%)	⬆️
internal/check/valid_owner_check.go	87.50% <87.50%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6c2ef...8316766. Read the comment docs.

[mszostok]

Hi

many thanks for your contribution!

I have one suggestion. Instead of hard-coding the @ghost user name, it would be better to export the option which takes a list of owners e.g. users, teams etc. that should be ignored by Valid Owner Checker.

1. Add IgnoreOwners []string `envconfig:"default=@ghost"` property in line 15 in file internal/check/valid_owner.go. In this way, this property can be automatically set by environment variable OWNER_CHECKER_IGNORE_OWNERS which can be populated with list of owners names that should be ignored and not validated e.g. "@user,@org/team1,@ghost"

2. In constructor NewValidOwner handle new cfg property and provide a func shouldIgnoreGitHubOwner(name) which can be used in for _, ownerName := range entry.Owners loop in line 63:

			if v.shouldIgnoreGitHubOwner(ownerName) {
				continue
			}

3. Update README.md that there is a new environment variable OWNER_CHECKER_IGNORE_OWNERS which can be used

4. Update action.yml with new property

If you will any help then ping me :) or if you will not have time to finish that then I can take it over if you want 👍

[mszostok]

Suggested change

	func isValidUser(user string) bool {
	func isValidOwner(user string) bool {

owner is a generic name for users, teams and emails :)

[mszostok]

Hi, I decided to merge that PR as it is 100% valid. I extracted the generalization logic to a saparate issue 👍 The user facing behaviour will stay the same, so by default the @ghost user will be deleted :)

Once again, thanks for your contribution and increasing test coverage 🚀

FYI: Integration tests are not executed on forked PR but I've checked it locally and all green 👍