Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions check to valid_owner #62

Merged
merged 2 commits into from
Jan 21, 2021

Commits on Jan 13, 2021

  1. Add permissions check to valid_owner

    Previously, the valid_owner check used the Repositories List Teams API
    endpoint to check if a team was valid. Due to an issue in the
    GitHub API, that endpoint does not return child teams that would
    inherit a parent team's permissions.
    
    This commit changes the initial check for the validity of a team to use
    the Teams List Teams API endpoint, which lists all teams in a org to
    check if the team exists at all. If that check fails, it will clearly
    state that the team does not exist.
    
    As a follow up to the initial valid team check, this commit checks the
    Teams IsTeamRepoBySlug endpoint, which returns an object containing the
    actual permissions for the team being checked on the repo. By adding
    this check, we can verify that a user can actually provide their review
    on PRs that made the CODEOWNERS line.
    highb committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    d03ee34 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Configuration menu
    Copy the full SHA
    bd0c80b View commit details
    Browse the repository at this point in the history