Use switching station ref counters #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also every switching station now works for supply/demand monitoring but instead of being activated by globalstep it uses switching station nodetimer:
|
|
Also brings little performance boost for globalstep for not checking switch node / mesecons and generally reduces globalstep loop code. |
|
For network.swpos hash table could be used for tiny bit faster lookup, I did think about it but decided to not do that because performance gain is minimal and also wont affect globalstep or any regular / timed functions. |
S-S-X
commented
May 1, 2022
Click for detailed source code test coverage reportTest coverage report for Technic CNC 87.33% in 11/14 files:Test coverage report for technic chests 45.56% in 6/6 files:Test coverage report for technic 60.76% in 95/95 files:Raw test runner output for geeks:CNC: Chests: Technic: |
wsor4035
approved these changes
May 1, 2022
|
can't test this right now but LGTM 👍 |
BuckarooBanzay
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation for issue #264
Removes switching station node checks from globalstep and uses switching station counters to decide if there's still switching stations present.
Switching stations can be removed from network without executing on_destruct but that should not really be big issue, network simply keeps running until TTL is reached and then stops.
Normal switching station removal will still reset network but now you can remove switching station above "master" node without resetting whole network, instead all switching stations have to be removed which is more correct behavior.