Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'include' to 'include_tasks' #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amritsingh
Copy link

Changed 'include' to 'include_tasks' as 'include' will be deprecated in ansible v2.8

Changes

Outline changes pull request is introducing

Verify

Add any steps on how to verify the changes work as intended


Add any relevant fixes or closes to reference github issues

@mtchavez
Copy link
Owner

mtchavez commented Nov 8, 2017

A few things here:

  • Looks like these changes introduce failures
    • Test failures are related to these changes as collectd appears to not have been ran correctly
  • There isn't any backwards compatibility for versions of ansible that don't know about include_tasks
  • In the future please follow the contributing templates provided for issues, pull requests, etc.

Open to getting this updated as it will slowly become deprecated. Just need to consider the backwards compatibility as well as making sure the tests pass.

@mtchavez mtchavez self-requested a review November 8, 2017 21:48
Copy link
Owner

@mtchavez mtchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing and backwards compatibility should be considered here for versions of ansible that my not have include_tasks

@amritsingh
Copy link
Author

The changes would work on version >= 2.4
On v2.4 this warning is displayed.
[DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions.
I will check how this can be handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants