Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side spectate on frontend too #7801

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Oct 9, 2024

ok I've done a couple of things here.

First:

  • only actually compute the spectator diffs if there are spectators (or during a resync/watch/join event)
    That should actually cut out a lot of processing I think.

Second:

  • If you're spectating as a specific side in an open-info game, flip the gameboard to that side
  • If you're spectating as a specific side in an open-info game, you can see prompts

Hopefully that should feel more natural, and it should help testing groups (or people learning to play) to do so more naturally without needing to communicate in riddles.

Webm is a bit choppy because weyland doesn't update that contexts unless the window is in an active browser context (needed three of them to demo this).

output.webm

@NoahTheDuke NoahTheDuke merged commit 299e3c1 into mtgred:master Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants