単語登録中に単語登録削除に遷移しキャンセルしたら単語登録中に戻るように修正 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtgto
commented
Jun 11, 2024
macSKK/StateMachine.swift
Outdated
| @@ -1032,8 +1039,15 @@ final class StateMachine { | |||
| } | |||
| return true | |||
| case .unregister: | |||
| let prevRegisterState: (RegisterState, [RegisterState])? | |||
| if case .register(let registerState, _) = specialState { | |||
| prevRegisterState = (registerState, []) | |||
There was a problem hiding this comment.
これだと再帰で単語登録しているときにそれを保持するようになってないので直す
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
単語登録中に単語登録解除に遷移してキャンセルしたときに想定された挙動になってなかったのを修正します。
再現手順
想定された動作
単語登録中の変換候補の選択中
実際の挙動
単語登録中ではない変換候補の選択中