Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): fix help option #176

Merged
merged 1 commit into from
Aug 6, 2019
Merged

chore(docs): fix help option #176

merged 1 commit into from
Aug 6, 2019

Conversation

mojoaxel
Copy link
Contributor

@mojoaxel mojoaxel commented Aug 3, 2019 •
edited
Loading

This should fix #53 after commander.js@3.0.0 is released.

see 3.0.0/CHANGELOG

@mojoaxel mojoaxel force-pushed the issue/53/help-option branch 2 times, most recently from d0400d8 to 4274395 Compare August 3, 2019 21:01
@mthenw
Copy link
Owner

mthenw commented Aug 6, 2019

Great stuff. I will review and test it later.

@mthenw mthenw marked this pull request as ready for review August 6, 2019 17:29
@mthenw
Copy link
Owner

mthenw commented Aug 6, 2019

I tested it and looks good.

@mthenw mthenw merged commit 364f68b into mthenw:master Aug 6, 2019
@mojoaxel
Copy link
Contributor Author

mojoaxel commented Aug 6, 2019

😟 commander.js has not yet been released, yet. This pull-request draft relies on a prerelease at the moment. It should not be released as it is at the moment.

After v3.0.0 has been released we should change the dependency and than we frontail should be released.

@mthenw
Copy link
Owner

mthenw commented Aug 6, 2019 •
edited
Loading

Yeah, I got it but I tested it and works fine. Have you spotted any errors?

@mojoaxel
Copy link
Contributor Author

mojoaxel commented Aug 6, 2019

Yeah, I got it but I tested it and works fine. Have you spotted any errors?

I'm just not sure if this 3.0.0-0 pre-release is reliable. I don't have a good feeling about this. But it works 👍

@mthenw
Copy link
Owner

mthenw commented Aug 6, 2019

OK, let's wait a few days. Maybe the release will happen in the meantime.

@mojoaxel
Copy link
Contributor Author

mojoaxel commented Aug 8, 2019

https://github.com/tj/commander.js/releases/tag/v3.0.0
@mthenw You can now update the dependency and release this 🚀

@mthenw
Copy link
Owner

mthenw commented Aug 8, 2019

It's not published to npm yet.

mojoaxel added a commit to mojoaxel/frontail that referenced this pull request Aug 30, 2019
@mojoaxel
update commander to 3.0.1
446c0ad 
see also mthenw#176
@mojoaxel mojoaxel mentioned this pull request Aug 30, 2019
Merged
mthenw pushed a commit that referenced this pull request Aug 30, 2019
@mojoaxel @mthenw
update commander to 3.0.1 (#182)
09acdc6 
see also #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README lists -h option as alias for both --help and --host
2 participants
@mojoaxel @mthenw