prevent accidental amalgamation of graphic token chars in output #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses mthom#2713. Many thanks to @notoria for reporting this excellent case! Example: ?- portray_clause(A = @). A= @ . true. At other positions the now inserted space is unnecessary, as in: ?- portray_clause((head:- @,b)). head :- @ , b. true. The toplevel has a similar issue: ?- C = # ; false. C = # |<-- cursor is here; redundant space after # There may be a way to solve this issue for all cases like this.
|
A way to avoid the extra space is to have a state to track the last character. This solves the issue though. |
Examples:
?- portray_clause(((+) :- a=b,(-))).
(+) :-
a=b,
(-).
true.
?- portray_clause((a :- (b :- c))).
a :-
(b:-c).
true.
This addresses mthom#2715.
Currently, more round brackets than needed are emitted. Ideally, a
better approach to solve the issue here and also in toplevel.pl is
found in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2713. Many thanks to @notoria for reporting this excellent case!
Example:
At other positions the now inserted space is unnecessary, as in:
The toplevel has a similar issue:
There may be a way to solve this issue for all cases like this.