Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ignore option to get_version and add shortcut #39

Merged
merged 5 commits into from
Jan 29, 2022
Merged

add ignore option to get_version and add shortcut #39

merged 5 commits into from
Jan 29, 2022

Conversation

marnikow
Copy link
Contributor

Two proposed edits:

  1. Add a ignore option to the get_version function
  2. Add a shortcut function that uses Version.from_any_vcs as third choice

mtkennerly
mtkennerly requested changes Jan 27, 2022
View reviewed changes
dunamai/__init__.py Outdated Show resolved Hide resolved
dunamai/__init__.py Outdated Show resolved Hide resolved
dunamai/__init__.py Outdated Show resolved Hide resolved
@mtkennerly mtkennerly added the enhancement New feature or request label Jan 27, 2022
mtkennerly
mtkennerly approved these changes Jan 29, 2022
View reviewed changes
Copy link
Owner

@mtkennerly mtkennerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good 👍

@mtkennerly mtkennerly merged commit cc0e53e into mtkennerly:master Jan 29, 2022
mtkennerly added a commit that referenced this pull request Jan 29, 2022
@mtkennerly
#39: Streamline code and add more tests
beba24c
@marnikow marnikow deleted the get_version_ignore branch January 30, 2022 13:59
@mtkennerly mtkennerly added this to the v1.9.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtkennerly mtkennerly mtkennerly approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marnikow @mtkennerly