Display file size #308
Merged
Display file size #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idk if you want this adding to the main release or not, I just wanted it for on my fork and thought you might be interested. Lmk if there's anything you'd want changed. |
|
Thanks! I think this is a great change. The only change I'd like, instead of putting the sizes in a column on the right, would be to put them as badges right after the file/folder name. I think that would be more consistent with the current design and would avoid the need to visually scan over a lot of blank space to match a file with its size. Like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays the size of a file or directory on the file tree.
Files and complete directories display file size, partially selected directories display selected / total, and unselected files and directories show the total size in grey.