Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title-casing optional #110

Closed
wants to merge 0 commits into from
Closed

Make title-casing optional #110

wants to merge 0 commits into from

Conversation

Goorzhel
Copy link
Contributor

@Goorzhel Goorzhel commented Jan 4, 2024

#!/usr/bin/env python

import beancount_chase

CONFIG = [
    beancount_chase.CreditImporter(
        "Liabilities:Chase", currency="USD", lastfour="....", title_case=False
    ),
]
❯ bean-extract config.py -f main.beancount download | grep SWENSENS -A2
2023-12-01 * "SWENSENS"
  Liabilities:Chase  -16.00 USD

Copy link
Owner

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

The changes look good, but would it be possible to add test cases to checking_test.py and credit_test.py to exercise the new behavior?

@Goorzhel
Copy link
Contributor Author

Goorzhel commented Jan 4, 2024

❯ pytest -r p | grep title_c
PASSED beancount_chase/checking_test.py::test_doesnt_title_case_if_asked_not_to
PASSED beancount_chase/credit_test.py::test_doesnt_title_case_if_asked_not_to

@mtlynch mtlynch closed this Jan 4, 2024
@mtlynch
Copy link
Owner

mtlynch commented Jan 4, 2024

@Goorzhel - Sorry, I was trying to push a formatting change (53a8c92) to this branch and accidentally pushed my master branch to yours. I re-did the PR in #112 and merged it in. I'll cut a release now.

@Goorzhel
Copy link
Contributor Author

Goorzhel commented Jan 4, 2024

No problem at all. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants