Display download count on file index #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Cool, thanks for working on this! Let me know when it's ready for review. If you haven't already, make sure to read the contributor's guide to get your PR merged quickly. |
gross2001
force-pushed
the
master
branch
2 times, most recently
from
1583f1b
to
7fafaf9
Compare
|
@mtlynch this PR is ready. |
mtlynch
changed the title
mtlynch
approved these changes
Apr 3, 2024
store/sqlite/entries.go
Outdated
| LEFT OUTER JOIN | ||
| ( | ||
| SELECT | ||
| entry_id, |
There was a problem hiding this comment.
Can we use tabs here so that it's aligned with the next line?
There was a problem hiding this comment.
Thanks, I fixed it
mtlynch
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
I didn't change GetEntryMetadata, even though it was required by the description of the issue. Because download count for a single file is already implemented and used via downloads, err := s.getDB(r).GetEntryDownloads(id), len(downloads). But I can change GetEntryMetadata too if this approach (through one request to sql and left join) looks better