Remove the russian tables from the LatexHyphenator configuration. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRambags
suggested changes
Feb 24, 2023
| @@ -96,7 +96,9 @@ | |||
|
|
|||
| <entry key="ro">resource-files/ro.xml</entry> | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
Please add a comment that explains why you've made this change
There was a problem hiding this comment.
Comment added.
bertfrees
approved these changes
Feb 24, 2023
PaulRambags
approved these changes
Feb 24, 2023
|
PR approved, running regression tests. |
|
Regression tests passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @PaulRambags and @bertfrees
This PR comment out the crashing Russian Latex rules (They crash on load, so they are useless).
I've prepared a UTF-8 version of the file and converted it with the substrings.pl script. This dictionary I've put locally in
/usr/share/hyphen.With these small changes, the Russian hyphenation will be handled by the Hunspell C library and use a local dictionary.
As it's loaded by C, we can't have the files bundled in the jar file. I currently don't have the time to write a java implementation for this format and MTM is waiting for a resolution to this problem. But it would be a fun challenge, and the explanation in Donald Knuth's book seems pretty straightforward, so that it might be a good replacement for the future.
Best regards
Daniel