Ensure files in sendfile calls are closed #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrudel
added a commit
to mtrudel/bandit
that referenced
this pull request
Oct 6, 2023
Also fix file always being closed after h2 sendfile file call, as in mtrudel/thousand_island#78
mtrudel
added a commit
to mtrudel/bandit
that referenced
this pull request
Oct 9, 2023
* Record HTTP/1 method in req * Support HEAD, 204, 304 quelling for HTTP/1 responses * Refactor h2 send_file logic Also fix file always being closed after h2 sendfile file call, as in mtrudel/thousand_island#78 * Record HTTP/2 method in req * Add content-length header to HTTP/2 sendfile responses * Support HEAD, 204, 304 quelling for HTTP/2 responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longstanding bug. Fixes mtrudel/bandit#209