Skip to content

Commit

Permalink
Version 1.0.1 - added acl, fixed code
Browse files Browse the repository at this point in the history
  • Loading branch information
mtrzk committed Sep 5, 2022
1 parent 3b7a025 commit 8e0f6a3
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 14 deletions.
10 changes: 9 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,16 @@ https://docs.google.com/forms/d/e/1FAIpQLSfT5F1VJXtBjGw2mLxY2aX557ctPTsCrJpURiKJ


## 4. CHANGELOG
Version 1.0.0

Version 1.0.1

```
- Fixed code after code review
- Added ACL for configuration
- Removed not used sequence in module
```

Version 1.0.0
```
- First commit
- Added support for Order emails
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "mtrzk/magento2-gmail-markup",
"description": "Magento 2 for Email Gmail Markup functionality",
"version": "1.0.0",
"version": "1.0.1",
"require": {
"php": ">=7.4.0",
"magento/module-sales": "*",
Expand Down
17 changes: 17 additions & 0 deletions etc/acl.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Acl/etc/acl.xsd">
<acl>
<resources>
<resource id="Magento_Backend::admin">
<resource id="Magento_Backend::stores">
<resource id="Magento_Backend::stores_settings">
<resource id="Magento_Config::config">
<resource id="Mtrzk_GmailMarkup::config" title="MTRZK Gmail markup" sortOrder="100"/>
</resource>
</resource>
</resource>
</resource>
</resources>
</acl>
</config>
2 changes: 1 addition & 1 deletion etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<section id="mtrzk_gmail_markup" translate="label" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Gmail Markup</label>
<tab>mtrzk_modules</tab>
<resource>Mtrzk_GmailMarkup::faqpage</resource>
<resource>Mtrzk_GmailMarkup::config</resource>
<group id="general" translate="label" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
<label>General</label>
<field id="is_enabled" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
Expand Down
6 changes: 0 additions & 6 deletions etc/di.xml

This file was deleted.

6 changes: 1 addition & 5 deletions etc/module.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Mtrzk_GmailMarkup" setup_version="1.0.0">
<sequence>
<module name="Mtrzk_Core"/>
</sequence>
</module>
<module name="Mtrzk_GmailMarkup" />
</config>

0 comments on commit 8e0f6a3

Please sign in to comment.