Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hive driver information #1290

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

samuelhsin
Copy link
Contributor

@samuelhsin samuelhsin commented Feb 28, 2024

Description:

This pull request introduces a Hive driver for SQLTools and includes updates to the README.md file to reflect the changes. The Hive driver facilitates seamless integration with SQLTools, enhancing its capabilities.

Changes Made:

Developed and added the Hive driver for SQLTools.
Updated information in README.md to include details about the newly added Hive driver.


  • [O] Your code builds clean without any errors or warnings
  • [O] You have made the needed changes to the docs
  • [O] You have written a description of what is the purpose of this pull request above

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing the link to your driver.

Please move the entry in README.md so alphabetical order is maintained.

Are you able to host the PNG image at GitHub rather than img.alicdn.com?

Please also add the information to docs/src/pages/en/drivers/drivers-table.mdx so it appears in the docs at https://vscode-sqltools.mteixeira.dev/en/drivers

@samuelhsin
Copy link
Contributor Author

samuelhsin commented Feb 28, 2024

Thanks for contributing the link to your driver.

Please move the entry in README.md so alphabetical order is maintained.

Are you able to host the PNG image at GitHub rather than img.alicdn.com?

Please also add the information to docs/src/pages/en/drivers/drivers-table.mdx so it appears in the docs at https://vscode-sqltools.mteixeira.dev/en/drivers

Hi, I already update readme files and also update drivers files. Please help review codes, thanks.

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gjsjohnmurray gjsjohnmurray merged commit 113013c into mtxr:dev Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants