Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite3 v5 #953

Merged
merged 21 commits into from
Sep 7, 2022
Merged

Sqlite3 v5 #953

merged 21 commits into from
Sep 7, 2022

Conversation

gjsjohnmurray
Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray commented Sep 5, 2022

Use sqlite@5.0.11 instead of @4.2.0

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #953 (d2eb00c) into dev (e5f12db) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #953   +/-   ##
=======================================
  Coverage   10.06%   10.06%           
=======================================
  Files         173      173           
  Lines        5834     5834           
  Branches     1366     1366           
=======================================
  Hits          587      587           
  Misses       5247     5247           
Flag Coverage Δ
extension 10.06% <0.00%> (ø)
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/driver.sqlite/src/ls/driver.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gjsjohnmurray
Copy link
Collaborator Author

@mtxr the aim of this PR is to resolve #858 and maybe #921.

I had also hoped to remove the need for install-time dependency resolution and building (see commit history of the PR), but failed at this so reverted that experiment's three commits.

The branch passed basic testing I performed using the /test/project.code-workspace

@gjsjohnmurray
Copy link
Collaborator Author

Zip of a manual build of the driver VSIX from this PR.

sqltools-driver-sqlite-0.3.1-dev.953.zip

@gjsjohnmurray gjsjohnmurray mentioned this pull request Sep 5, 2022
5 tasks
packages/driver.sqlite/package.json Outdated Show resolved Hide resolved
packages/driver.sqlite/src/ls/driver.ts Outdated Show resolved Hide resolved
@gjsjohnmurray gjsjohnmurray merged commit a049e68 into mtxr:dev Sep 7, 2022
@gjsjohnmurray gjsjohnmurray deleted the sqlite3-v5 branch September 7, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants