Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid infinity loop if auto install fails for drivers #955

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

mtxr
Copy link
Owner

@mtxr mtxr commented Sep 7, 2022

Describe here what is this PR about and what we are achieving merging this.

I realized that when installing some drivers if the npm install fails, the terminal auto closes making it harder for the users to provide feedback. Also that was cause the install flow to stay in a loop.

This PR address this issue.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #955 (dd92ea8) into dev (a049e68) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #955   +/-   ##
=======================================
  Coverage   10.06%   10.06%           
=======================================
  Files         173      173           
  Lines        5834     5832    -2     
  Branches     1366     1366           
=======================================
  Hits          587      587           
+ Misses       5247     5245    -2     
Flag Coverage Δ
extension 10.06% <0.00%> (+<0.01%) ⬆️
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...connection-manager/dependency-manager/extension.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gjsjohnmurray
Copy link
Collaborator

gjsjohnmurray commented Sep 7, 2022

I suppose this may help us diagnose #921 if the answers to my latest questions there don't lead to a breakthrough.

@mtxr mtxr merged commit ed5c08e into dev Sep 7, 2022
@mtxr mtxr deleted the fix/infinity-loop-on-auto-install-fails branch September 7, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants