Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry to enter raw repl when listing fs #2378

Closed
wants to merge 1 commit into from

Conversation

gschaden
Copy link

Sometimes the repl response is not detected on my esp32.
Might also solve #2360

@ntoll
Copy link
Member

ntoll commented Jan 9, 2023

👋 @gschaden could you please make these changes to the upstream module https://github.com/ntoll/microfs ..? Thank you..!

serial.write(b"\r\x01")
flush_to_msg(serial, raw_repl_msg)
break
except:

Check notice

Code scanning / CodeQL

Except block handles 'BaseException'

Except block directly handles BaseException.
serial.write(b"\r\x01")
flush_to_msg(serial, raw_repl_msg)
break
except:

Check notice

Code scanning / CodeQL

Empty except

'except' clause does nothing but pass and there is no explanatory comment.
@gschaden
Copy link
Author

gschaden commented Jan 10, 2023

Sent to upstream request https://github.com/ntoll/microfs/pull/40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants