Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(go-piper): update to 2023.11.6-3 #1257

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

M0Rf30
Copy link
Collaborator

@M0Rf30 M0Rf30 commented Nov 7, 2023

Description

This PR fixes go-piper compilation

Notes for Reviewers
It is linked to mudler/go-piper#1
Tested on a complete rebuild with GO_TAGS="tts" and the example reported in the official docs
All the *.so
and required backend assets (espeak-ng-data) will live under go-piper/piper/build/pi

Signed commits

  • Yes, I signed my commits.

Makefile Outdated Show resolved Hide resolved
@M0Rf30 M0Rf30 force-pushed the fix/go-piper branch 4 times, most recently from 0237f81 to a36ee1b Compare November 8, 2023 23:05
@mudler
Copy link
Owner

mudler commented Nov 9, 2023

this is looking good! however @M0Rf30 somehow the pinning of the go-piper commit was overwritten, without it will still use the old go-piper version

@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Nov 9, 2023

this is looking good! however @M0Rf30 somehow the pinning of the go-piper commit was overwritten, without it will still use the old go-piper version

I removed any reference to updated go-piper commit. I've seen that the bot automatically updates the commits, looking at the other repos.
Please give me suggestions on how to manage this. Should I bump the commit here?should I wait for go-piper PR to be merged?

@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Nov 9, 2023

Here we go. I also updated the commit

mudler
mudler previously approved these changes Nov 9, 2023
@mudler mudler enabled auto-merge (squash) November 9, 2023 17:43
@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Nov 9, 2023

Ok got it, I need to rework the CI test steps. otherwise stable-diffusion will always fail

auto-merge was automatically disabled November 10, 2023 19:13

Head branch was pushed to by a user without write access

@M0Rf30 M0Rf30 force-pushed the fix/go-piper branch 6 times, most recently from f68434f to eee2b6d Compare November 10, 2023 19:54
@M0Rf30
Copy link
Collaborator Author

M0Rf30 commented Nov 10, 2023

CGO for flags for piper now have a specific name in the Makefile. this avoid conflicts on unneeded libs/includes for stablediffusion when both GO_TAGS are called.

ESPEAK_DATA now points to piper shipped resources and go-piper is a mandatory dep for backend-assets/espeak-ng-data

@M0Rf30 M0Rf30 force-pushed the fix/go-piper branch 5 times, most recently from d8422c9 to 104e9b3 Compare November 11, 2023 00:13
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution, thanks @M0Rf30 for keeping trying :)

@mudler mudler changed the title Makefile: update go-piper with piper 2023.11.6-3 deps(go-piper): update to 2023.11.6-3 Nov 11, 2023
@mudler mudler merged commit bde87d0 into mudler:master Nov 11, 2023
8 checks passed
@M0Rf30 M0Rf30 deleted the fix/go-piper branch November 11, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants