-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(go-piper): update to 2023.11.6-3 #1257
Conversation
0237f81
to
a36ee1b
Compare
this is looking good! however @M0Rf30 somehow the pinning of the go-piper commit was overwritten, without it will still use the old go-piper version |
I removed any reference to updated go-piper commit. I've seen that the bot automatically updates the commits, looking at the other repos. |
Here we go. I also updated the commit |
Ok got it, I need to rework the CI test steps. otherwise stable-diffusion will always fail |
Head branch was pushed to by a user without write access
f68434f
to
eee2b6d
Compare
CGO for flags for piper now have a specific name in the Makefile. this avoid conflicts on unneeded libs/includes for stablediffusion when both GO_TAGS are called. ESPEAK_DATA now points to piper shipped resources and go-piper is a mandatory dep for backend-assets/espeak-ng-data |
d8422c9
to
104e9b3
Compare
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contribution, thanks @M0Rf30 for keeping trying :)
Description
This PR fixes go-piper compilation
Notes for Reviewers
It is linked to mudler/go-piper#1
Tested on a complete rebuild with GO_TAGS="tts" and the example reported in the official docs
All the *.so
and required backend assets (espeak-ng-data) will live under go-piper/piper/build/pi
Signed commits