Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect OpenAI spec for response format #1289

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: respect OpenAI spec for response format #1289

merged 1 commit into from
Nov 15, 2023

Conversation

mudler
Copy link
Owner

@mudler mudler commented Nov 15, 2023

Description

Otherwise we fail with:

failed to generate answer: error, status code: 500, message: failed reading parameters from request:failed parsing request body: json: cannot unmarshal object into Go struct field OpenAIRequest.response_format of type string

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mudler
fix: properly respect OpenAI spec for response format
83423a5 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@mudler mudler changed the title fix: properly respect OpenAI spec for response format fix: respect OpenAI spec for response format Nov 15, 2023
@mudler mudler added the bug Something isn't working label Nov 15, 2023
@mudler mudler merged commit 66a558f into master Nov 15, 2023
13 of 14 checks passed
@mudler mudler deleted the json_type branch November 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mudler