Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Features->Embeddings page to reflect backend restructuring #1325

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

B4ckslash
Copy link
Contributor

Description
The documentation website was out of date with regards to the path of the backend to run huggingface models. Since it moved to backend/python/sentencetransformers, I updated the documentation accordingly so that people running LocalAI outside of Docker can continue to do so.

I also changed the naming in the example YAML file to refer to the sentencetransformers backend instead of the huggingface-embeddings backend. The docker version of LocalAI knows both as an alias for the same backend, so this should not break anything there.

P.S.: Perhaps the docs should be updated to give an example on how to use the transformers backend as well? As I don't know what it is used for nor how one might use it, I wasn't able to include it in this PR.

Notes for Reviewers
The renaming from huggingface-embeddings to sentencetransformers is a separate commit, so if you don't like it, I can easily remove it from this PR.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Marcus Köhler <khler.marcus@gmail.com>
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 9db7cfa
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6560a06b697a9700083254e8
😎 Deploy Preview https://deploy-preview-1325--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…d for consistency with the backend structure

The Dockerfile still knows the "huggingface-embeddings"
backend (I assume for compatibility reasons) but uses the
sentencetransformers backend under the hood anyway.

I figured it would be good to update the docs to use the new naming to
make it less confusing moving forward. As the docker container knows
both the "huggingface-embeddings" and the "sentencetransformers"
backend, this should not break anything.

Signed-off-by: Marcus Köhler <khler.marcus@gmail.com>
@lunamidori5 lunamidori5 self-assigned this Nov 24, 2023
@lunamidori5 lunamidori5 added the kind/documentation Improvements or additions to documentation label Nov 24, 2023
Copy link
Collaborator

@lunamidori5 lunamidori5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but Ill let the others also review

@lunamidori5
Copy link
Collaborator

P.S.: Perhaps the docs should be updated to give an example on how to use the transformers backend as well? As I don't know what it is used for nor how one might use it, I wasn't able to include it in this PR.

@B4ckslash yes I think so, you are super welcome to make a how to page or edit the embedding one to add this if you like, or ill get one made asap

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good here, thanks!

@mudler mudler merged commit 5a6a6de into mudler:master Nov 24, 2023
18 checks passed
@B4ckslash B4ckslash deleted the website_embeddings_update branch November 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants