fix: handle grpc and llama-cpp with REBUILD=true #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai canceled.
|
mudler
force-pushed
the
fix_rebuild_container
branch
3 times, most recently
from
6d8e371
to
162f82a
Compare
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
force-pushed
the
fix_rebuild_container
branch
from
162f82a
to
0e949b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
REBUILD=truein the container which currently is broken.It was caused by not handling llama.cpp source code and the grpc dependencies not installed in the final container.
This PR handles now explicitly adds in the Makefile an entry to clone the source code during the preparation of the sources and it copies the grpc built artifacts over the running container and installing them.