Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate CMAKE_ARGS when building grpc #1334

Merged
merged 1 commit into from
Nov 25, 2023
Merged

fix: propagate CMAKE_ARGS when building grpc #1334

merged 1 commit into from
Nov 25, 2023

Conversation

mudler
Copy link
Owner

@mudler mudler commented Nov 25, 2023

Description

This PR fixes #1317

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mudler mudler linked an issue Nov 25, 2023 that may be closed by this pull request
Custom CMAKE_ARGS are overwritten in the "backend/cpp/llama/grpc-server" target for the "llama-cpp" backend #1317
Closed
@mudler mudler added the bug Something isn't working label Nov 25, 2023
@mudler
fix: propagate CMAKE_ARGS when building grpc
9717490 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2023 •
edited
Loading

✅ Deploy Preview for localai canceled.

Name Link
🔨 Latest commit 9717490
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6561c00eb32c6a000810990f

@mudler mudler merged commit 6f34e8f into master Nov 25, 2023
24 of 38 checks passed
@mudler mudler deleted the fix_cmake branch November 25, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom CMAKE_ARGS are overwritten in the "backend/cpp/llama/grpc-server" target for the "llama-cpp" backend
1 participant
@mudler