Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/docs: Python backend dependencies #1360

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

B4ckslash
Copy link
Contributor

Description

In #1279, the requirements.txt file got dropped from the extra/ directory during the move to a backend/ directory. As the docs still refer to that file (and it's useful to have a central list of the necessary pip packages), I re-added it with the same content under backend/python.

I also updated the Features->Embeddings docs page to use the new path in the pip install command.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for localai canceled.

Name Link
🔨 Latest commit 7b4b852
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6568aca1c825ac0008f13ff8

@mudler
Copy link
Owner

mudler commented Nov 29, 2023

The docs should be updated to run make prepare-extra-conda-environments instead. The mentioned requirements.txt would not really cover the deps that are needed otherwise.

make prepare-extra-conda-environments prepares the conda environments for each backend, so library versions are taken care of as well.

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs to mention make prepare-extra-conda-environments instead - the requirements.txt file is not used and maintained anymore

@B4ckslash
Copy link
Contributor Author

The docs should be updated to run make prepare-extra-conda-environments instead. The mentioned requirements.txt would not really cover the deps that are needed otherwise.

make prepare-extra-conda-environments prepares the conda environments for each backend, so library versions are taken care of as well.

I see. I'll fix that up and also add in conda as a required dependency for python backends on the embeddings page.

If it's okay with you, I'd also fix up the Makefiles in the backends, as they all have .PONY targets instead of .PHONY targets.

@B4ckslash B4ckslash changed the title feat/docs: Re-add requirements.txt in backend/python fix/docs: Python backend dependencies Nov 30, 2023
Signed-off-by: Marcus Köhler <khler.marcus@gmail.com>
Signed-off-by: Marcus Köhler <khler.marcus@gmail.com>
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mudler mudler merged commit 2d64d8b into mudler:master Nov 30, 2023
18 checks passed
@B4ckslash B4ckslash deleted the python_requirements branch December 1, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants