fix: OSX Build Fix Part 1: Metal #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudler
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
fantastic, thanks @dave-gray101 - it looks good here but I cannot test on Mac (yet?) so gonna have to trust you here :)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out I had not in fact, made Metal the default on OSX for LocalAI to match llama.cpp (where it matters most) - and because of that, I have not been testing with
BUILD_TYPE=metalfor a while... and metal builds were broken due to the backend refactoring.This PR addresses this issue by:
ggml-metal.metalpathBUILD_TYPE=metalthe default ifBUILD_TYPEisn't specified at all and we're on mac so this doesn't happen againAs a sidenote,
GO_TAGS=stablediffusionon osx is also not currently using brew opencv - that will be corrected in a followup PR as I want to get this one merged first.