-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track internally started models by ID #3693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nice change @mudler |
siddimore
reviewed
Sep 30, 2024
siddimore
reviewed
Oct 1, 2024
mudler
force-pushed
the
chore/refactor_modelID
branch
2 times, most recently
from
October 1, 2024 10:34
f77f5fa
to
ae1a7c7
Compare
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
force-pushed
the
chore/refactor_modelID
branch
from
October 1, 2024 21:52
8ded837
to
4ad5b57
Compare
dave-gray101
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how we track models that are being loaded. Instead of refering to the model's file and path, we are going to track now the model ID. The model ID is also the name of each model that can be specified with a
name
- in this way we keep a 1:1 mapping and we fallback into using the model file name if a model name is not provided.This allows for instance now to have the same backing model to be loaded with different parameters, and helps also into understanding which models are loaded as it now references what is returned when we list available models or models loaded in
/system
.This pull request includes significant changes to the model loading and backend configuration processes in the codebase. The changes primarily focus on improving the flexibility and robustness of model handling by introducing a new
modelID
parameter and refactoring related functions.Copilot summary
Model Loading Enhancements:
modelID
parameter in theOptions
struct and related functions to uniquely identify models. (pkg/model/options.go
) [1] [2]LoadModel
function to usemodelID
for loading and checking models. (pkg/model/loader.go
) [1] [2] [3]Backend Configuration Improvements:
modelOpts
to include default options and handlemodelID
. (core/backend/options.go
)modelID
parameter. (core/backend/embeddings.go
,core/backend/image.go
,core/backend/llm.go
) [1] [2] [3] [4]GRPC Model Loading Adjustments:
grpcModel
function to accommodate themodelID
parameter and ensure proper logging and error handling. (pkg/model/initializers.go
) [1] [2] [3] [4] [5] [6] [7] [8]Testing Updates:
modelID
parameter and updated test cases accordingly. (pkg/model/loader_test.go
)tests/e2e-aio/e2e_test.go
)