fix(initializer): correctly reap dangling processes #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -376,7 +376,9 @@ | |||
|
|
|||
| if !ready { | |||
| log.Debug().Msgf("GRPC Service NOT ready") | |||
| ml.deleteProcess(o.model) | |||
| if process := client.Process(); process != nil { | |||
| process.Stop() | |||
Check warning
Code scanning / gosec
Errors unhandled. Warning
| @@ -388,11 +390,15 @@ | |||
|
|
|||
| res, err := client.GRPC(o.parallelRequests, ml.wd).LoadModel(o.context, &options) | |||
| if err != nil { | |||
| ml.deleteProcess(o.model) | |||
| if process := client.Process(); process != nil { | |||
| process.Stop() | |||
Check warning
Code scanning / gosec
Errors unhandled. Warning
| return nil, fmt.Errorf("could not load model: %w", err) | ||
| } | ||
| if !res.Success { | ||
| ml.deleteProcess(o.model) | ||
| if process := client.Process(); process != nil { | ||
| process.Stop() |
Check warning
Code scanning / gosec
Errors unhandled. Warning
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a current existing issue when starting new processes. If the backend fails, for instance by loading the model and the model was not explicitly configured with a
backend, LocalAI would loop over the backends - however if it fails it won't reap the process, and callingdeleteProcessis a no-op as the model isn't registered yet.Notes for Reviewers
Signed commits