Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listmodelservice / welcome endpoint use LOOSE_ONLY #3791

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

dave-gray101
Copy link
Collaborator

Description

This PR fixes #3790 - simplifies welcome.go by using LOOSE_ONLY, repairs it in listmodelservice

Notes for Reviewers
quick PR, seems to work in my simple mac testing.

Signed-off-by: Dave Lee <dave@gray101.com>
Signed-off-by: Dave Lee <dave@gray101.com>
@dave-gray101 dave-gray101 enabled auto-merge (squash) October 11, 2024 18:50
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit f629841
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/670973819ef8e000087aaf68
😎 Deploy Preview https://deploy-preview-3791--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dave-gray101 dave-gray101 changed the title Fix: listmodelservice / welcome endpoint use LOOSE_ONLY fix: listmodelservice / welcome endpoint use LOOSE_ONLY Oct 11, 2024
@dave-gray101 dave-gray101 requested a review from mudler October 11, 2024 20:50
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dave-gray101 dave-gray101 merged commit 65ca754 into mudler:master Oct 11, 2024
29 of 30 checks passed
@mudler mudler added the bug Something isn't working label Oct 11, 2024
@dave-gray101 dave-gray101 deleted the fix-listmodelservice-1 branch October 12, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants