Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#pragma once #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#pragma once #1

wants to merge 1 commit into from

Conversation

adamnemecek
Copy link

No description provided.

@muellan
Copy link
Owner

muellan commented Jun 4, 2018

#pragma once

  • is not part of any C++ standard (this is why I decided against it)
  • the current code should work fine, even with those compilers that might not support it
  • the PR does not add any functionality or fix any bugs (as far as I can tell)

@adamnemecek
Copy link
Author

adamnemecek commented Jun 4, 2018

It removes 70 lines of code, that's functionality of sorts. Also every single C++ compiler that people use recognizes this pragma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants