Fix entity filter #597
Merged
Fix entity filter #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! The filters are working fine in Firefox, I actually never realized they were broken in Chrome. While you're on it, could you please also add functionality to reset the respective filters when going back to Filter by language ... (etc.) in the dropdown? This should revert back to an unfiltered view. Essentially just the way it currently works in Firefox. That would be great! |
|
Sorry, for only providing half of the fix at the start. Commit ed8ad01 should do it. |
|
Great contribution, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dropdown menus to filter for project, language, machine, and label are not working because the selection on the EntityFilter is not updated when selecting a new value. This PR set the selection from the event target.