Allow browse start node id to be specified in the template #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pkamps
commented
Nov 27, 2018
pkamps
commented
- placeholder -
peterkeung
reviewed
Nov 27, 2018
| @@ -156,7 +156,9 @@ | |||
| {undef $loop_count} | |||
| {/if} | |||
| {if and( not( $is_dynamic ), not( $is_custom ) )} | |||
| {def $start_browse_node_id = first_set( ezini( $block.type, 'ManualBlockStartBrowseNode', 'block.ini' ), 2 )} | |||
There was a problem hiding this comment.
I wouldn't default to "2", because this changes the behavior. Instead, only output the hidden input field if the INI value is set.
(eZContentBrowse has its own INI fallback.)
Technically this is also a BC break if you have an override of block/edit/edit.tpl already. You would lose the ManualBlockStartBrowseNode effect. I would have put the fallback ManualBlockStartBrowseNode logic into PHP:
if( $http->hasVariable( 'start-browse-node-id' ) )
...
elseif( $blockINI->hasVariable( $block->attribute( 'type' ), 'ManualBlockStartBrowseNode' ) )
...
... then the template just has a commented out hidden input field for a developer to use or not.
|
+1 |
|
Upstream pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.