Moving yui 2.7.0 to legacy extension #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 versions of YUI in the ez code base:
2.7.0 under design/standard
2.8.2 under extension/ezjscore
3.17.2 under extension/ezjscore
YUI 2 is very different to YUI 3 - that's why both libs are installed and used.
The admin UI heavily relies on YUI, so the ezjscore extension is always enabled.
The lib 2.7.0 only have a few files that also exists in the 2.8.2 version. So, if ezjscore is enabled, all YUI2 code is using the 2.8.2 version.
For backwards compatibility, I decided to not delete the 2.7.0 lib but to move it into the legacy_2018 extension.