-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Use getOptionLabel over stringify #19974
[Autocomplete] Use getOptionLabel over stringify #19974
Conversation
Details of bundle changes.Comparing: 05c992e...33d7fa3
|
by default (mui#19798)
a2d5318
to
2ec30fc
Compare
Hey y'all. Not sure what argos is - anyone know what the issue might be with the PNG stream? |
@a-type This Argos issue has been around for a week now, it's frustrating. It originates in the PNG cropping module. It fails in https://github.com/nathanmarks/vrtest/blob/e2240dc018d3392ca232712bb34aef7b80ee1000/src/server/utils/screenshots.js#L5. |
Maybe we should apply the same patch gemini-testing/looks-same#24. |
@a-type Thanks! |
of options against input value
Closes #19798
Updates
createFilterOptions
to not provide a defaultstringify
, but still allows the user to specify one. If nostringify
is supplied, the filter will usegetOptionLabel
as passed touseAutocomplete
. The goal here is to keep the searching as predictable to the user as possible by matching against what they're actually seeing on screen, without requiring the developer to have to think too much about the inner workings of filtering by default.