[test] Resize screenshots with sharp #19979
Merged
+190
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
try-vrtest-fork
branch
4 times, most recently
from
d8f77c2
to
0546850
Compare
|
No bundle size changes comparing 0048575...4a6201b |
oliviertassinari
force-pushed
the
try-vrtest-fork
branch
from
0546850
to
201bbe3
Compare
eps1lon
reviewed
Mar 4, 2020
oliviertassinari
force-pushed
the
try-vrtest-fork
branch
from
201bbe3
to
4a6201b
Compare
oliviertassinari
changed the title
eps1lon
reviewed
Mar 4, 2020
eps1lon
pushed a commit
to eps1lon/material-ui
that referenced
this pull request
Mar 4, 2020
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effort is motivated by the recent flaky CI fails, for instance, #19974.
It uses sharp over png-crop.
Outside of the flaky issue, it also seems to reduce the overall CI duration of 30s 😄.