Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Resize screenshots with sharp #19979

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 4, 2020

This effort is motivated by the recent flaky CI fails, for instance, #19974.
It uses sharp over png-crop.
Outside of the flaky issue, it also seems to reduce the overall CI duration of 30s 😄.

@oliviertassinari oliviertassinari force-pushed the try-vrtest-fork branch 4 times, most recently from d8f77c2 to 0546850 Compare March 4, 2020 11:08
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 4, 2020

No bundle size changes comparing 0048575...4a6201b

Generated by 🚫 dangerJS against 4a6201b

package.json Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari marked this pull request as ready for review March 4, 2020 11:49
@oliviertassinari oliviertassinari changed the title [test] Try screenshot resize with sharp [test] Resize screenshots with sharp Mar 4, 2020
package.json Show resolved Hide resolved
@oliviertassinari oliviertassinari merged commit d68e273 into mui:master Mar 4, 2020
@oliviertassinari oliviertassinari deleted the try-vrtest-fork branch March 4, 2020 13:05
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Mar 4, 2020
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants