-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add color preview to default theme tree #20082
Conversation
Details of bundle changes.Comparing: 7e1da61...00ca1ac Details of page changes
|
I'm currently trying to debug the failed argos test, if someone has any idea as to why they're failing could you let me know? |
@mlizchap Likely a false alarm. Is your branch up to date with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet changes :)
ddb831e
to
00ca1ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have applied the code review of Sebastian, we should be good to go 😍
@mlizchap Great work. This looks awesome! |
Thanks for getting to this @oliviertassinari! And thanks for the review @eps1lon! Material UI has been my first open source contribution ❤️ |
fixes #20077
https://deploy-preview-20082--material-ui.netlify.com/customization/default-theme/#explore
Note: let me know if I should write tests for these