Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CircularProgress] Remove static variant, simplify determinate #22060

Merged
merged 1 commit into from
Aug 7, 2020
Merged

[CircularProgress] Remove static variant, simplify determinate #22060

merged 1 commit into from
Aug 7, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 3, 2020 •
edited by oliviertassinari
Loading

Breaking change

  • The static variant has been merged into the determinate variant, with the latter assuming the appearance of the former.
    The removed variant was rarely useful. It was an exception to Material Design, and was removed from the specification.

    -<CircularProgress variant="determinate" />
    -<CircularProgress variant="static" classes={{ static: 'className' }} />
+<CircularProgress variant="determinate" classes={{ determinate: 'className' }} />

NB: If you had previously customized determinate, your customizations are probably no longer valid. Please remove them.

Motivation: #7223 (comment)
Closes #20548

oliviertassinari
oliviertassinari reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably leave a note in the migration guide

packages/material-ui/src/CircularProgress/CircularProgress.test.js Outdated Show resolved Hide resolved
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 3, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against bcf3ee0

@mbrookes mbrookes force-pushed the circularprogress-remove-static-variant branch 2 times, most recently from b1cf723 to 5e399a2 Compare August 3, 2020 22:25
@mbrookes

This comment has been minimized.

Sign in to view
@mbrookes mbrookes added this to the v5 milestone Aug 4, 2020
@oliviertassinari oliviertassinari mentioned this pull request Aug 4, 2020
Closed
@mbrookes mbrookes force-pushed the circularprogress-remove-static-variant branch from 5e399a2 to 8b523c8 Compare August 4, 2020 22:17
@oliviertassinari oliviertassinari force-pushed the circularprogress-remove-static-variant branch from 47ce9c0 to 9b07f3e Compare August 5, 2020 20:54
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 6, 2020
@mbrookes mbrookes force-pushed the circularprogress-remove-static-variant branch from 5d54b8d to bcf3ee0 Compare August 6, 2020 18:02
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 6, 2020
@github-actions github-actions bot mentioned this pull request Aug 6, 2020
Closed
@mbrookes mbrookes mentioned this pull request Aug 6, 2020
Merged
1 task
@eps1lon eps1lon merged commit 5e12d7c into mui:next Aug 7, 2020
@mbrookes mbrookes deleted the circularprogress-remove-static-variant branch August 7, 2020 17:56
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@oliviertassinari oliviertassinari mentioned this pull request Jan 27, 2021
Closed
2 tasks
@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.

[CircularProgress] Remove determinate variant
4 participants
@mbrookes @mui-pr-bot @oliviertassinari @eps1lon