Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings for v5 #22074

Closed
33 of 42 tasks
eps1lon opened this issue Aug 5, 2020 · 8 comments
Closed
33 of 42 tasks

Deprecation warnings for v5 #22074

eps1lon opened this issue Aug 5, 2020 · 8 comments
Labels
deprecation New deprecation message umbrella For grouping multiple issues to provide a holistic view
Milestone
v5

Comments

@eps1lon
Copy link
Member

eps1lon commented Aug 5, 2020 •
edited by mnajdova
Loading

This is a tracking issue for deprecation warnings for breaking changes in v5. The list can be updated with https://cijbg.csb.app/ which also helps identifying missing deprecation warnings.

If you see issues with individual items please open a separate issues (otherwise the conversation will be hard to follow since GitHub has no threading).

List of breaking changes

A checked checkbox means we have a deprecation warning, unchecked means no deprecation warning and line-through means there's a rationale why we don't intend to add one.
Paste below list source back into https://cijbg.csb.app/ to have it updated.
WARNING: DO NOT MANUALLY CHECK ITEMS. ONLY STRIKETHROUGH WITH A RATIONALE IS ACCEPTED
@eps1lon eps1lon added umbrella For grouping multiple issues to provide a holistic view deprecation New deprecation message labels Aug 5, 2020
@eps1lon eps1lon added this to the v5 milestone Aug 5, 2020
@mui mui locked and limited conversation to collaborators Aug 5, 2020
@oliviertassinari
Copy link
Member

@m4theushw We haven't updated this issue for 4 months. Do you want to double-check that we didn't miss any deprecations?

@oliviertassinari oliviertassinari modified the milestones: v5-beta, v5 Jun 15, 2021
@oliviertassinari
Copy link
Member

It seems that the codesandbox script is no longer working. It would be great to update it to double-check that we don't have any opportunities left for deprecations on v4.

@mnajdova
Copy link
Member

As far as I can see all Breaking Changes which are part of the PR description are handled. I've runned the script again, by selecting the milestone: v5-beta, and these were the only items there:

I believe we can close. cc @oliviertassinari @eps1lon

@eps1lon
Copy link
Member Author

eps1lon commented Aug 17, 2021

It seems that the codesandbox script is no longer working. It would be great to update it to double-check that we don't have any opportunities left for deprecations on v4.

It wasn't working because you changed the milestone title without telling anybody.

I believe we can close. cc @oliviertassinari @eps1lon

Yep, looks good 👍🏻

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 17, 2021 •
edited
Loading

The GraphQL query we run is limited to 100 results, we have 244 PRs that match. The records: https://codesandbox.io/s/recursing-jang-y0w5h?file=/src/data.json

I went on updating the breaking changes PRs that we did to add the missing v5-beta milestone label. I didn't update them all, I ignored the ones that seem impossible to add a deprecation for. I have updated the list in the issue's description. It seems that we could do some work on v4 deprecations. Is it important enough? I don't know.

@mnajdova
Copy link
Member

Looking into the breaking changes left here are my thoughts:

[core] Remove makeStyles from @material-ui/core
[core] Remove styled from @material-ui/styles in core
[core] Remove withTheme from @material-ui/core

There are lots of options here of how people may migrate (using @material-ui/styes, using tss-react, migration to styled() and sx, I don't think we can have a clear migration message that would fit them all) I wouldn't add a deprecation in v4 for them.

[core] Drop support for node 10
[types] Bump minimum required TypeScript version to 3.5

Can't add deprecation notes

[Select] Remove labelWidth prop

I don't think we can easily support this with deprecation message, as the whole CSS is changed.

[system] Use spacing unit in gap, row-gap, and column-gap
[system] Make borderRadius multiply a theme's design token

These are ones that we could consider supporting the prev implementation with deprecation. Not sure if it is worthed to be honest.

@eps1lon
Copy link
Member Author

eps1lon commented Aug 18, 2021

I think we've made a good faith effort to add as many deprecation warnings as possible. There's a long tail of issues that I would love to see handled but I don't think it's worth the time of core members.

@oliviertassinari
Copy link
Member

Closing and using the newly opened GitHub issues to refine the priorities on the v4 to v5 migration pain sounds 👌.

@eps1lon eps1lon closed this as completed Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
deprecation New deprecation message umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Milestone
v5
Development

No branches or pull requests
3 participants
@oliviertassinari @mnajdova @eps1lon