[Grid] Add deprecation for justify prop rename #24078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: Grid
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: e9542ee...9370c6f Details of page changes
|
42 tasks
mbrookes
reviewed
Dec 20, 2020
| /* Styles applied to the root element if `justify="center"`. */ | ||
| 'justify-xs-center': { | ||
| /* Styles applied to the root element if `justifyContent="center"`. */ | ||
| 'justify-content-xs-center': { |
There was a problem hiding this comment.
In theory, it's a breaking change. In practice, is there a use case for using these class names? I think that it's negligible. If you feel that it's too risky, happy to take a step back. I went with the fastest possible approach so far.
There was a problem hiding this comment.
No, I think it's pretty safe. I ignored a similar change in another deprecation PR review.
mnajdova
reviewed
Dec 22, 2020
Comment on lines
+122
to
+136
| /** | ||
| * Defines the number of grids the component is going to use. | ||
| * It's applied for the `lg` breakpoint and wider screens if not overridden. | ||
| */ | ||
| lg?: boolean | GridSize; | ||
| /** | ||
| * Defines the number of grids the component is going to use. | ||
| * It's applied for the `md` breakpoint and wider screens if not overridden. | ||
| */ | ||
| md?: boolean | GridSize; | ||
| /** | ||
| * Defines the number of grids the component is going to use. | ||
| * It's applied for the `sm` breakpoint and wider screens if not overridden. | ||
| */ | ||
| sm?: boolean | GridSize; |
There was a problem hiding this comment.
These props did not exist before, I believe we should drop them.
There was a problem hiding this comment.
These xs, sm, md, etc. props were already coming from:
We made them explicit. It's coming from the commit on v5 that I cherry-picked.
mnajdova
reviewed
Dec 22, 2020
mnajdova
reviewed
Dec 22, 2020
oliviertassinari
force-pushed
the
grid-prop-change
branch
from
48b4603
to
5bf7047
Compare
mnajdova
approved these changes
Dec 22, 2020
oliviertassinari
added a commit
that referenced
this pull request
Jan 24, 2021
oliviertassinari
added a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deprecation for #21845.