Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Rename fade to alpha #22834

Merged
merged 20 commits into from
Oct 7, 2020
Merged

[theme] Rename fade to alpha #22834

merged 20 commits into from
Oct 7, 2020

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Oct 2, 2020 •
edited by oliviertassinari
Loading

Breaking changes

  • Renamed fade to alpha to better describe its functionality.
- import { fade } from '@material-ui/core/styles';
+ import { alpha } from '@material-ui/core/styles';
const classes = makeStyles(theme => ({
-  backgroundColor: fade(theme.palette.primary.main, theme.palette.action.selectedOpacity),
+  backgroundColor: alpha(theme.palette.primary.main, theme.palette.action.selectedOpacity),
}));

Part of #20012, the change is discussed in #13039 (comment).

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 2, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 9775213

@mnajdova mnajdova marked this pull request as ready for review October 2, 2020 09:30
@mbrookes mbrookes mentioned this pull request Oct 2, 2020
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 2, 2020
mbrookes
mbrookes previously requested changes Oct 3, 2020
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md Outdated Show resolved Hide resolved
packages/material-ui/src/styles/colorManipulator.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari changed the title [theme] rename fade to alpha [theme] Rename fade to alpha Oct 3, 2020
@oliviertassinari oliviertassinari added this to the v5 milestone Oct 3, 2020
@oliviertassinari oliviertassinari mentioned this pull request Oct 3, 2020
Merged
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 7, 2020
@github-actions github-actions bot mentioned this pull request Oct 7, 2020
Closed
@mnajdova mnajdova merged commit b3cd80d into mui:next Oct 7, 2020
@oliviertassinari oliviertassinari mentioned this pull request Oct 10, 2020
Closed
2 tasks
@oliviertassinari oliviertassinari mentioned this pull request Oct 22, 2020
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes Awaiting requested review from mbrookes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@mnajdova @mui-pr-bot @mbrookes @oliviertassinari