Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove dangerfile #1307

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[core] Remove dangerfile #1307

merged 1 commit into from
Jan 8, 2025

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 8, 2025 •
edited
Loading

Replaced custom danger-based site deployment notifications with the one coming from Netlify for better DX.

Before:
image

After:
image

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Jan 8, 2025
@michaldudak michaldudak requested a review from atomiks as a code owner January 8, 2025 11:55
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit ddc2dda
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/677e67c4bbe9880008b02f9f
😎 Deploy Preview https://deploy-preview-1307--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaldudak michaldudak requested a review from colmtuite January 8, 2025 12:11
@michaldudak michaldudak merged commit fda6b0a into mui:master Jan 8, 2025
24 checks passed
@michaldudak michaldudak deleted the remove-dangerfile branch January 8, 2025 12:49
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 10, 2025 •
edited
Loading

Replaced custom danger-based site deployment notifications with the one coming from Netlify for better DX.

I'm not following, what's the advantage? This looks like the DX regressed here. The problems with this approach:

I have preventively removed the Netlify comment, assuming the case is convincing and we will take the step backward. But maybe I'm missing something, and the points I listed aren't less of a pain than the reason behind this change.

@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Jan 10, 2025
@michaldudak
Copy link
Member Author

The main advantage for me is having the deployment URL available as a QR code. I'm sure it would be possible to implement it using danger, but this was the simplest way. We currently don't use danger for anything else. Could you please re-enable Netlify comments? When we implement any new features with danger, we can come back to it.

@oliviertassinari oliviertassinari mentioned this pull request Jan 13, 2025
Open
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 13, 2025 •
edited
Loading

available as a QR code

Ok, restored, and issue created for where we are heading: mui/mui-public#261.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 14, 2025 •
edited
Loading

If we move to Vercel to host the docs, this issue would make sense too, e.g. chakra-ui/chakra-ui#9470 (comment) the QR code is not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @oliviertassinari @mnajdova