[core] Optionally delay useTransitionStatus's entering status with a param
#887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
mj12albert
force-pushed
the
fix/delay-starting-transition-status
branch
3 times, most recently
from
0d49af3
to
247a12e
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
commented
Nov 28, 2024
| * @ignore - internal hook. | ||
| */ | ||
| export function useTransitionStatus(open: boolean, enabled = true) { | ||
| export function useTransitionStatus(open: boolean, enabled = true, delayStartingStatus = false) { |
There was a problem hiding this comment.
Yeah I haven't renamed it internally, so we should match entering
mj12albert
changed the title
useTransitionStatus's entering/starting status with a paramuseTransitionStatus's entering status with a param
mj12albert
force-pushed
the
fix/delay-starting-transition-status
branch
from
247a12e
to
5e827dc
Compare
atomiks
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #807 (comment) since
keepMounted={false}needs some reworkCollapsible depends on having 1 frame between
openandenteringto measure the size of the panel contentshttps://deploy-preview-887--base-ui.netlify.app/experiments/collapsible-transitions