Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global overrides support missing #1356

Closed
marcusjwhelan opened this issue Oct 14, 2019 · 8 comments
Closed

Global overrides support missing #1356

marcusjwhelan opened this issue Oct 14, 2019 · 8 comments
Labels
bug 🐛 Something isn't working good to take Help wanted
Milestone

Comments

@marcusjwhelan
Copy link

Is your feature request related to a problem? Please describe.
Trying to add @media change width of items or text size depending on screen size. One size
does not fit all.

Describe the solution you'd like
Would be nice to have a list of CSS items to build off of. Currently in the docs there are only
a few and some don't even work, for instance MuiPickersModal: dialogAction options do not work currently with material-ui 4.4.3

Describe alternatives you've considered
It would be nice not to have to copy my entire custom theme just to add a couple overrides. Tried just having the Overrides in and it reset all my settings on top of that one element. So I had to copy and paste my entire custom theme into another file and then paste the overrides in there for it to work.

@marcusjwhelan
Copy link
Author

holy cow batman. Had to uninstall. no way to customize easily

@spudcud
Copy link

spudcud commented Oct 15, 2019

I also ran into the issue that MuiPickersModal: dialogAction doesn't work. It is in the samples but no luck. You have to override MuiButton directly in order to get it to change.

@oliviertassinari oliviertassinari changed the title CSS Overide options Global overrides support missing Mar 31, 2020
@oliviertassinari oliviertassinari added bug 🐛 Something isn't working good to take Help wanted labels Mar 31, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 31, 2020

This is also the same issue as #1340 at the difference that only point 2. is required to solve the problem. Given that a couple of style sheets already have a name, it's about a systematized solution.

On the documentation side of the CSS overrides, relying on the infrastructure of the core would solve the problem, hence it's a matter of advancing mui/material-ui#19706.

@Philipp91
Copy link
Contributor

Side question: Is this the right way to import the type for the overrides?

import {MuiPickersOverrides} from '@material-ui/pickers/src/typings/overrides';
                                                        ^^^

@dmtrKovalenko
Copy link
Member

Must be without src

@Philipp91
Copy link
Contributor

Well then it complains: TS2307: Cannot find module '@material-ui/pickers/typings/overrides'.

So perhaps you need to add an export?

@oliviertassinari
Copy link
Member

So perhaps you need to add an export?

@Philipp91 For this matter, please see #1874.

@oliviertassinari oliviertassinari modified the milestones: v4, v5 Jul 13, 2020
@dmtrKovalenko
Copy link
Member

It is fixed already and both props and css overrides available as for v4 alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good to take Help wanted
Projects
None yet
Development

No branches or pull requests

5 participants