Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve theme augmentation #1874

Closed
oliviertassinari opened this issue Jun 9, 2020 · 1 comment
Closed

Improve theme augmentation #1874

oliviertassinari opened this issue Jun 9, 2020 · 1 comment
Labels
breaking change good to take Help wanted typescript

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 9, 2020 •
edited
Loading

In #1858, we have started to uncover a couple of improvement opportunities around how the theme's type can be extended. I would propose we update the approach to match the main repository.
If anyone is interested it's up for grab, it should be as easy as following mui/material-ui#21279.
@oliviertassinari oliviertassinari changed the title Update theme augmentation to match main repository Improve theme augmentation Jun 15, 2020
@oliviertassinari oliviertassinari mentioned this issue Jun 15, 2020
Closed
@rajzik rajzik mentioned this issue Aug 24, 2020
Closed
1 task
@oliviertassinari
Copy link
Member Author

I believe we have solved the issue by moving the component to the lab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change good to take Help wanted typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature theme augmentation rajzik/material-ui-pickers
1 participant
@oliviertassinari