Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature theme augmentation #2092

Closed
wants to merge 4 commits into from
Closed

Conversation

rajzik
Copy link

@rajzik rajzik commented Aug 24, 2020

Fixes: #1874

This PR will unify the approach to the material-ui monorepo see: https://github.com/mui-org/material-ui/tree/next/packages/material-ui-lab/src/themeAugmentation

I also added documentation for the theme augmentation as well as fixed component names to correspond with theme overrides.

@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/mb1m25znv
✅ Preview: https://material-ui-pickers-git-fork-rajzik-feat-theme-augmentation.mui-org.vercel.app

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 24, 2020

@rajzik Thanks for the effort. Note that we are working on merging the components into the lab in https://github.com/mui-org/core-plus-pickers. We will have to redo this pull request on https://github.com/mui-org/material-ui once the migration is completed.

@rajzik
Copy link
Author

rajzik commented Aug 24, 2020

@oliviertassinari oh, nvm. If you need any help just let me know.

@oliviertassinari
Copy link
Member

I will let you know :)

@rajzik
Copy link
Author

rajzik commented Aug 31, 2020

@oliviertassinari is there any estimation when the migration will be done?

@oliviertassinari
Copy link
Member

@dmtrKovalenko is making great progress. I think that so far, the main blocker is to reach a point where https://github.com/mui-org/core-plus-pickers/tree/next/packages/pickers is no longer included in the repository.

@oliviertassinari
Copy link
Member

@rajzik Thanks for the effort! I believe we have solved the issue by moving the component in the lab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve theme augmentation
2 participants