Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive DatePicker broken in v4-alpha.8 #1882

Closed
michael-land opened this issue Jun 11, 2020 · 3 comments · Fixed by #1884
Closed

Responsive DatePicker broken in v4-alpha.8 #1882

michael-land opened this issue Jun 11, 2020 · 3 comments · Fixed by #1884
Assignees
@michael-land
Labels
docs good to take Help wanted

Comments

@michael-land
Copy link
Contributor

michael-land commented Jun 11, 2020 •
edited
Loading

https://v4-0-0-alpha-8.material-ui-pickers.dev/demo/datepicker#responsiveness

image
@oliviertassinari
Copy link
Member

What do you mean by it's broken? Do you have a reproduction?

@oliviertassinari oliviertassinari added the status: incomplete Need more information label Jun 11, 2020
@michael-land
Copy link
Contributor Author

michael-land commented Jun 11, 2020 •
edited
Loading

Should it render mobile date picker on small screen.

https://v4-0-0-alpha-5.material-ui-pickers.dev/demo/datepicker#responsiveness

===

image

https://v4-0-0-alpha-8.material-ui-pickers.dev/demo/datepicker#responsiveness

image

@oliviertassinari oliviertassinari added docs and removed status: incomplete Need more information labels Jun 11, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 11, 2020 •
edited
Loading

@xiaoyu-tamu The description of the section is wrong. We forgot to update it. Do you want to work on it? :)

Date/Time pickers experience is extremely different on mobile and desktop. Here is how components will look on different devices. The default Datepicker component is responsive, which means that Mobile or Desktop mode will be rendered according to device viewport.

The desktop vs mobile split is determined by the pointer support of the device. If the pointer is touch, it uses the Mobile version. If the pointer is fine (mouse), it uses the Desktop version.

@oliviertassinari oliviertassinari added the good to take Help wanted label Jun 11, 2020
michael-land added a commit to michael-land/material-ui-pickers that referenced this issue Jun 11, 2020
@michael-land
[docs] Update responsiveness section
41cbd89 
close mui#1882
@michael-land michael-land mentioned this issue Jun 11, 2020
Merged
dmtrKovalenko added a commit that referenced this issue Jun 19, 2020
@michael-land @oliviertassinari @dmtrKovalenko
[docs] Improve Responsiveness sections (#1884)
50ee6e9 
* [docs] Update responsiveness section

close #1882

* Update index.mdx

* Update index.mdx

* Update docs/pages/demo/datepicker/index.mdx

* apply same description to the other components

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-land michael-land

Labels
docs good to take Help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Improve Responsiveness sections michael-land/material-ui-pickers
2 participants
@oliviertassinari @michael-land