-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix core@v4.9.9 support with createSvgIcon #1629
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/eipm1aa2t |
Missed global module name in rollup config. But everything else looks good |
Thx for the quick review @dmtrKovalenko ! I'm not sure about this two files: and
Can you help me? |
In typings — remove our overrides.
|
Codecov Report
@@ Coverage Diff @@
## next #1629 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 64 64
Lines 1797 1797
Branches 324 307 -17
=======================================
Hits 1655 1655
Misses 108 108
Partials 34 34
Continue to review full report at Codecov.
|
Awesome ! Thx @oliviertassinari & @dmtrKovalenko ! |
Yeah, will publish it asap. Probably tomorrow. |
Update import of
createSvgIcon
according to closes #1619.