Fix importing error for reexported adapters #1634
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/am4mh3rh6 |
|
|
||
| function createAdapterPackageFile(name) { | ||
| const packageJson = { | ||
| name: `@material-ui/pickers-adapter-${name}`, |
There was a problem hiding this comment.
@oliviertassinari What do you think will be the best name for adapter package.json?
BTW @material-ui/pickers/adapter/${name} is not a valid name for package.json
There was a problem hiding this comment.
Do we even need to provide a name? For instance: https://unpkg.com/browse/@material-ui/core@4.9.9/Badge/package.json.
There was a problem hiding this comment.
We had mui/material-ui#15715, but it seemed fine.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## next #1634 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 73 73
Lines 2315 2315
Branches 420 420
=======================================
Hits 2078 2078
Misses 190 190
Partials 47 47 Continue to review full report at Codecov.
|
|
Should we update the documentation at the same time? |
|
There is no breaking changes. Documentation was already updated — just not working |
|
Note, codesandbox-ci could have helped to test the changes. We have configured it on the mono repository. |
This PR closes #1627
Description
In order to make esm build work we need to provide separate
package.jsonfor each of adapter folder